Skip to content

Implement test- naming convention for CI jobs - #162092

Open
Kobzol wants to merge 9 commits into
rust-lang:mainfrom
Kobzol:ci-job-refactor
Open

Implement test- naming convention for CI jobs#162092
Kobzol wants to merge 9 commits into
rust-lang:mainfrom
Kobzol:ci-job-refactor

Conversation

@Kobzol

@Kobzol Kobzol commented Aug 31, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

This PR implements a naming convention for all jobs. Either they have to start with dist- (jobs that build artifacts) or test- (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu

@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

@rustbot rustbot added A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Sort CI jobs
6cc3eda 
To make it easier to search through them in the GitHub UI.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Sep 1, 2026
View reviewed changes
Comment thread src/ci/docker/host-x86_64/test-pr-check-1/Dockerfile
jieyouxu
jieyouxu approved these changes Sep 1, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green

View changes since this review

@Kobzol

Kobzol commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu rollup=never note="Renames many CI jobs"

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d1b8536 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
@bors
Auto merge of #162092 - Kobzol:ci-job-refactor, r=jieyouxu
0516e91 
Implement test- naming convention for CI jobs

This PR implements a naming convention for all jobs. Either they have to start with `dist-` (jobs that build artifacts) or `test-` (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2026
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0516e91 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2026
@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 28293c4 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Zalathar
Zalathar reviewed Sep 4, 2026
View reviewed changes
Comment thread src/ci/github-actions/jobs.yml Outdated
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2026
@Kobzol

Kobzol commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu p=0

@rust-bors

rust-bors Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 017c9e0 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
@bors
Auto merge of #162092 - Kobzol:ci-job-refactor, r=jieyouxu
58ccc21 
Implement test- naming convention for CI jobs



This PR implements a naming convention for all jobs. Either they have to start with `dist-` (jobs that build artifacts) or `test-` (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2026
@rust-bors

rust-bors Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 58ccc21 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu

jieyouxu commented Sep 6, 2026

Copy link
Copy Markdown
Member

Hm

sh: line 1: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh: No such file or directory

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026
@Kobzol

Kobzol commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=test-x86_64-msvc-ext3

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
@bors
Auto merge of #162092 - Kobzol:ci-job-refactor, r=<try>
2854698 
Implement test- naming convention for CI jobs


try-job: test-x86_64-msvc-ext3
@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 2854698 (285469853b4bce3d46e751e195e76a1fd3e61e54)
Base parent: 46a266b (46a266b9fb0fb75e05fa4c9132f7355fcb62d4a4)

@Kobzol

Kobzol commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 109408c has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zalathar Zalathar Zalathar left review comments
@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol @rustbot @rust-log-analyzer @JonathanBrouwer @jieyouxu @Zalathar